From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link
 management
Date: Tue, 13 Nov 2018 21:58:45 +0100
Message-ID: <20181113205845.GB9828@lunn.ch>
References: <cover.1542119058.git.igor.russkikh@aquantia.com>
 <cb00d2c12713bd3973f36b4ad46e4574fa26a774.1542119058.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:33799 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728730AbeKNG6n (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 14 Nov 2018 01:58:43 -0500
Content-Disposition: inline
In-Reply-To: <cb00d2c12713bd3973f36b4ad46e4574fa26a774.1542119058.git.igor.russkikh@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Nov 13, 2018 at 02:44:45PM +0000, Igor Russkikh wrote:
> From: Dmitry Bezrukov <dmitry.bezrukov@aquantia.com>
> 
> Add full hardware initialization sequence and link configuration logic

Hi Igor

I'm still not convinced the PHY driver should be embedded in the MAC
driver, rather than using phylink.

If i remember correctly, it was because the MAC is involved in
determining if the link is up? That is nothing new. phylink expects
this. The MAC driver should call phylink_mac_change() when the MACs
SERDES goes up/down.

       Andrew