From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet
Date: Tue, 13 Nov 2018 22:02:41 +0100 [thread overview]
Message-ID: <20181113210241.GC9828@lunn.ch> (raw)
In-Reply-To: <ba4572f1eae5c93fa643520647ea214bcef79b1e.1542119058.git.igor.russkikh@aquantia.com>
> +static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
> +{
> +
> + if (aqc111_data->dpa) {
> + aqc111_set_phy_speed(dev, AUTONEG_ENABLE, SPEED_100);
So this is better, you leave auto-neg enabled. But you really should
be taking the link partners capabilities into account.
Andrew
next prev parent reply other threads:[~2018-11-14 7:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 14:44 [PATCH v2 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 04/21] net: usb: aqc111: Various callbacks implementation Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 05/21] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management Igor Russkikh
2018-11-13 20:58 ` Andrew Lunn
2018-11-14 7:44 ` Igor Russkikh
2018-11-14 21:16 ` Andrew Lunn
2018-11-14 22:53 ` Florian Fainelli
2018-11-16 9:53 ` Igor Russkikh
2018-11-16 18:33 ` Andrew Lunn
2018-11-13 14:44 ` [PATCH v2 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 08/21] net: usb: aqc111: Implement TX data path Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 09/21] net: usb: aqc111: Implement RX " Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 10/21] net: usb: aqc111: Add checksum offload support Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 11/21] net: usb: aqc111: Add support for changing MTU Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 13/21] net: usb: aqc111: Add support for TSO Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks Igor Russkikh
2018-11-13 20:50 ` Andrew Lunn
2018-11-14 7:46 ` Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Igor Russkikh
2018-11-13 21:02 ` Andrew Lunn [this message]
2018-11-14 7:56 ` Igor Russkikh
2018-11-14 21:30 ` Andrew Lunn
2018-11-13 14:45 ` [PATCH v2 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113210241.GC9828@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).