From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake
 on LAN by MAGIC packet
Date: Tue, 13 Nov 2018 22:02:41 +0100
Message-ID: <20181113210241.GC9828@lunn.ch>
References: <cover.1542119058.git.igor.russkikh@aquantia.com>
 <ba4572f1eae5c93fa643520647ea214bcef79b1e.1542119058.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:33803 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725748AbeKNHCj (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 14 Nov 2018 02:02:39 -0500
Content-Disposition: inline
In-Reply-To: <ba4572f1eae5c93fa643520647ea214bcef79b1e.1542119058.git.igor.russkikh@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
> +{

> +
> +		if (aqc111_data->dpa) {
> +			aqc111_set_phy_speed(dev, AUTONEG_ENABLE, SPEED_100);

So this is better, you leave auto-neg enabled. But you really should
be taking the link partners capabilities into account.

   Andrew