From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [iproute PATCH] ip-route: Fix nexthop encap parsing Date: Wed, 14 Nov 2018 11:20:52 -0800 Message-ID: <20181114112052.16bee62f@shemminger-XPS-13-9360> References: <20181113123904.27880-1-phil@nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Phil Sutter Return-path: Received: from mail-pf1-f177.google.com ([209.85.210.177]:46241 "EHLO mail-pf1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOFZX (ORCPT ); Thu, 15 Nov 2018 00:25:23 -0500 Received: by mail-pf1-f177.google.com with SMTP id s9-v6so8370749pfm.13 for ; Wed, 14 Nov 2018 11:20:55 -0800 (PST) In-Reply-To: <20181113123904.27880-1-phil@nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 13 Nov 2018 13:39:04 +0100 Phil Sutter wrote: > When parsing nexthop parameters, a buffer of 4k bytes is provided. Yet, > in lwt_parse_encap() and some functions called by it, buffer size was > assumed to be 1k despite the actual size was provided. This led to > spurious buffer size errors if the buffer was filled by previous nexthop > parameters to exceed that 1k boundary. > > Fixes: 1e5293056a02c ("lwtunnel: Add encapsulation support to ip route") > Fixes: 5866bddd9aa9e ("ila: Add support for ILA lwtunnels") > Fixes: ed67f83806538 ("ila: Support for checksum neutral translation") > Fixes: 86905c8f057c0 ("ila: support for configuring identifier and hook types") > Fixes: b15f440e78373 ("lwt: BPF support for LWT") > Signed-off-by: Phil Sutter Applied