From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet
Date: Wed, 14 Nov 2018 22:30:38 +0100 [thread overview]
Message-ID: <20181114213038.GG32305@lunn.ch> (raw)
In-Reply-To: <3c322e27-06c7-69a1-cbe8-271741da0bb3@aquantia.com>
> We've considered that, but then thought about the following case:
>
> After such a sleep state where partner's capabilities were considered,
> user may move with the unit and replug it into different link partner with
> other, incompatible speed mask. That will anyway lead to wol link failure.
WOL for a nomadic device? Is that even a real use case?
Anyway, looking at the link partner capabilities is just really a
corner case, that the LP only supports 1G. Do such devices exist?
So skipping this is fine. But if you use phylib, you pretty much get
it for free if you want it.
Andrew
next prev parent reply other threads:[~2018-11-15 7:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 14:44 [PATCH v2 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 04/21] net: usb: aqc111: Various callbacks implementation Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 05/21] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management Igor Russkikh
2018-11-13 20:58 ` Andrew Lunn
2018-11-14 7:44 ` Igor Russkikh
2018-11-14 21:16 ` Andrew Lunn
2018-11-14 22:53 ` Florian Fainelli
2018-11-16 9:53 ` Igor Russkikh
2018-11-16 18:33 ` Andrew Lunn
2018-11-13 14:44 ` [PATCH v2 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 08/21] net: usb: aqc111: Implement TX data path Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 09/21] net: usb: aqc111: Implement RX " Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 10/21] net: usb: aqc111: Add checksum offload support Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 11/21] net: usb: aqc111: Add support for changing MTU Igor Russkikh
2018-11-13 14:44 ` [PATCH v2 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 13/21] net: usb: aqc111: Add support for TSO Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks Igor Russkikh
2018-11-13 20:50 ` Andrew Lunn
2018-11-14 7:46 ` Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Igor Russkikh
2018-11-13 21:02 ` Andrew Lunn
2018-11-14 7:56 ` Igor Russkikh
2018-11-14 21:30 ` Andrew Lunn [this message]
2018-11-13 14:45 ` [PATCH v2 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids Igor Russkikh
2018-11-13 14:45 ` [PATCH v2 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114213038.GG32305@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).