From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake
 on LAN by MAGIC packet
Date: Wed, 14 Nov 2018 22:30:38 +0100
Message-ID: <20181114213038.GG32305@lunn.ch>
References: <cover.1542119058.git.igor.russkikh@aquantia.com>
 <ba4572f1eae5c93fa643520647ea214bcef79b1e.1542119058.git.igor.russkikh@aquantia.com>
 <20181113210241.GC9828@lunn.ch>
 <3c322e27-06c7-69a1-cbe8-271741da0bb3@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:34909 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726269AbeKOHfg (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 15 Nov 2018 02:35:36 -0500
Content-Disposition: inline
In-Reply-To: <3c322e27-06c7-69a1-cbe8-271741da0bb3@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> We've considered that, but then thought about the following case:
> 
> After such a sleep state where partner's capabilities were considered,
> user may move with the unit and replug it into different link partner with
> other, incompatible speed mask. That will anyway lead to wol link failure.

WOL for a nomadic device? Is that even a real use case?

Anyway, looking at the link partner capabilities is just really a
corner case, that the LP only supports 1G. Do such devices exist?

So skipping this is fine. But if you use phylib, you pretty much get
it for free if you want it.

   Andrew