From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Lance Roy <ldr709@gmail.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 01/14] i40e: Replace spin_is_locked() with lockdep
Date: Wed, 14 Nov 2018 15:10:19 -0800 [thread overview]
Message-ID: <20181114231032.4013-2-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20181114231032.4013-1-jeffrey.t.kirsher@intel.com>
From: Lance Roy <ldr709@gmail.com>
lockdep_assert_held() is better suited to checking locking requirements,
since it won't get confused when someone else holds the lock. This is
also a step towards possibly removing spin_is_locked().
Signed-off-by: Lance Roy <ldr709@gmail.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 21c2688d6308..7e4c07227832 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1493,8 +1493,7 @@ int i40e_del_mac_filter(struct i40e_vsi *vsi, const u8 *macaddr)
bool found = false;
int bkt;
- WARN(!spin_is_locked(&vsi->mac_filter_hash_lock),
- "Missing mac_filter_hash_lock\n");
+ lockdep_assert_held(&vsi->mac_filter_hash_lock);
hash_for_each_safe(vsi->mac_filter_hash, bkt, h, f, hlist) {
if (ether_addr_equal(macaddr, f->macaddr)) {
__i40e_del_filter(vsi, f);
--
2.19.1
next prev parent reply other threads:[~2018-11-15 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 23:10 [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-11-14 Jeff Kirsher
2018-11-14 23:10 ` Jeff Kirsher [this message]
2018-11-14 23:10 ` [net-next 02/14] i40e: Use a local variable for readability Jeff Kirsher
2018-11-14 23:10 ` [net-next 03/14] i40e: Add capability flag for stopping FW LLDP Jeff Kirsher
2018-11-14 23:10 ` [net-next 04/14] i40e: Replace strncpy with strlcpy to ensure null termination Jeff Kirsher
2018-11-14 23:10 ` [net-next 05/14] i40e: Protect access to VF control methods Jeff Kirsher
2018-11-14 23:10 ` [net-next 06/14] i40e: update driver version Jeff Kirsher
2018-11-14 23:10 ` [net-next 07/14] i40e: Allow disabling FW LLDP on X722 devices Jeff Kirsher
2018-11-14 23:10 ` [net-next 08/14] i40e: don't restart nway if autoneg not supported Jeff Kirsher
2018-11-14 23:10 ` [net-next 09/14] i40e: always set ks->base.speed in i40e_get_settings_link_up Jeff Kirsher
2018-11-14 23:10 ` [net-next 10/14] virtchnl: white space and reorder Jeff Kirsher
2018-11-14 23:10 ` [net-next 11/14] virtchnl: Fix off by one error Jeff Kirsher
2018-11-14 23:10 ` [net-next 12/14] i40e: Use correct shift for VLAN priority Jeff Kirsher
2018-11-14 23:10 ` [net-next 13/14] i40e: suppress bogus error message Jeff Kirsher
2018-11-14 23:10 ` [net-next 14/14] i40e: prevent overlapping tx_timeout recover Jeff Kirsher
2018-11-15 23:06 ` [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-11-14 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114231032.4013-2-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=ldr709@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox