From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver Date: Thu, 15 Nov 2018 09:56:22 -0800 (PST) Message-ID: <20181115.095622.889070618474069350.davem@davemloft.net> References: <20181115052327.2859-1-xuechaojing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com, tony.qu@huawei.com, luoshaokai@huawei.com To: xuechaojing@huawei.com Return-path: In-Reply-To: <20181115052327.2859-1-xuechaojing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Xue Chaojing Date: Thu, 15 Nov 2018 05:23:27 +0000 > This patch fixes these problems: > 1. In order to improve performance, this patch add rx checksum offload > for the HiNIC driver. Performance test(Iperf) shows more than 95% > improvement in TCP streams. > 2. In add_mac_addr(), if the MAC address is a muliticast address, it > will not be set, which causes the network card fail to receive the > multicast packet. This patch fixes this bug. > 3. In rx_alloc_pkts(), there is a loop call of tasklet, which causes > 100% cpu utilization, even no packets are being received. This patch > fixes this bug. > > Signed-off-by: Xue Chaojing Each patch should do one thing. Please don't combine multiple changes into one patch like this. Post a proper patches series, one change per patch, with a proper "[PATCH 0/N] " header posting preceeding the series. Thanks.