From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next v2] net: dump more useful information in netdev_rx_csum_fault() Date: Thu, 15 Nov 2018 11:37:33 -0800 (PST) Message-ID: <20181115.113733.1378650897811910132.davem@davemloft.net> References: <20181112224718.19496-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:45210 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725742AbeKPFqm (ORCPT ); Fri, 16 Nov 2018 00:46:42 -0500 In-Reply-To: <20181112224718.19496-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Mon, 12 Nov 2018 14:47:18 -0800 > Currently netdev_rx_csum_fault() only shows a device name, > we need more information about the skb for debugging csum > failures. > > Sample output: > > ens3: hw csum failure > dev features: 0x0000000000014b89 > skb len=84 data_len=0 pkt_type=0 gso_size=0 gso_type=0 nr_frags=0 ip_summed=0 csum=0 csum_complete_sw=0 csum_valid=0 csum_level=0 > > Note, I use pr_err() just to be consistent with the existing one. > > Signed-off-by: Cong Wang Applied, thanks Cong.