From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter
 applies to EDT flows
Date: Thu, 15 Nov 2018 11:42:44 -0800 (PST)
Message-ID: <20181115.114244.2161851080298657768.davem@davemloft.net>
References: <20181113001716.150039-1-edumazet@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
To: edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:45358 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725742AbeKPFv4 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Nov 2018 00:51:56 -0500
In-Reply-To: <20181113001716.150039-1-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <edumazet@google.com>
Date: Mon, 12 Nov 2018 16:17:16 -0800

> When EDT conversion happened, fq lost the ability to enfore a maxrate
> for all flows. It kept it for non EDT flows.
> 
> This commit restores the functionality.
> 
> Tested:
> 
> tc qd replace dev eth0 root fq maxrate 500Mbit
> netperf -P0 -H host -- -O THROUGHPUT
> 489.75
> 
> Fixes: ab408b6dc744 ("tcp: switch tcp and sch_fq to new earliest departure time model")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.