From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dalon Westergreen Subject: [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call Date: Wed, 14 Nov 2018 16:50:41 -0800 Message-ID: <20181115005047.28464-3-dwesterg@gmail.com> References: <20181115005047.28464-1-dwesterg@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Dalon Westergreen To: netdev@vger.kernel.org, dinguyen@kernel.org, thor.thayer@linux.intel.com Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:33989 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbeKOK4g (ORCPT ); Thu, 15 Nov 2018 05:56:36 -0500 Received: by mail-pl1-f194.google.com with SMTP id f12-v6so8624247plo.1 for ; Wed, 14 Nov 2018 16:51:00 -0800 (PST) In-Reply-To: <20181115005047.28464-1-dwesterg@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Dalon Westergreen It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index dcb330129e23..0c0e8f9bba9b 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1166,6 +1166,10 @@ static int tse_open(struct net_device *dev) int i; unsigned long int flags; + /* set tx and rx ring size */ + priv->rx_ring_size = dma_rx_num; + priv->tx_ring_size = dma_tx_num; + /* Reset and configure TSE MAC and probe associated PHY */ ret = priv->dmaops->init_dma(priv); if (ret != 0) { @@ -1208,8 +1212,6 @@ static int tse_open(struct net_device *dev) priv->dmaops->reset_dma(priv); /* Create and initialize the TX/RX descriptors chains. */ - priv->rx_ring_size = dma_rx_num; - priv->tx_ring_size = dma_tx_num; ret = alloc_init_skbufs(priv); if (ret) { netdev_err(dev, "DMA descriptors initialization failed\n"); -- 2.19.1