netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: jiangyiwen <jiangyiwen@huawei.com>
Cc: stefanha@redhat.com, stefanha@gmail.com,
	Jason Wang <jasowang@redhat.com>,
	netdev@vger.kernel.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC] Discuss about an new idea "Vsock over Virtio-net"
Date: Thu, 15 Nov 2018 02:04:52 -0500	[thread overview]
Message-ID: <20181115015547-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5BECEE53.7090408@huawei.com>

On Thu, Nov 15, 2018 at 11:56:03AM +0800, jiangyiwen wrote:
> Hi Stefan, Michael, Jason and everyone,
> 
> Several days ago, I discussed with jason about "Vsock over Virtio-net".
> This idea has two advantages:
> First, it can use many great features of virtio-net, like batching,
> mergeable rx buffer and multiqueue, etc.
> Second, it can reduce many duplicate codes and make it easy to be
> maintained.

I'm not sure I get the motivation. Which features of
virtio net are relevant to vsock? The ones that you mention
all seem to be mostly of use to the networking stack.


> Before the implement, I want to discuss with everyone again, and
> want to know everyone's suggestions.
> 
> After the discussion, based on this point I will try to implement
> this idea, but I am not familiar with the virtio-net, that is a
> pity. :(
>
> -------------------------Simple idea------------------------------
> 
> 1. The packet layout will become as follows:
> 
> +---------------------------------+
> |        Virtio-net header        |
> |(struct virtio_net_hdr_mrg_rxbuf)|

Which fields in virtio_net_hdr_mrg_rxbuf are of interest to vsock?

> +---------------------------------+
> |          Vsock header           |
> |    (struct virtio_vsock_hdr)    |
> +---------------------------------+
> |             payload             |
> |      (until end of packet)      |
> +---------------------------------+

Thanks,
-- 
MST

  parent reply	other threads:[~2018-11-15 17:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  3:56 [RFC] Discuss about an new idea "Vsock over Virtio-net" jiangyiwen
2018-11-15  4:19 ` Jason Wang
2018-11-15  6:46   ` jiangyiwen
2018-11-15  6:49     ` jiangyiwen
2018-11-15  8:19     ` Jason Wang
2018-11-15  9:02       ` jiangyiwen
2018-11-15  9:21         ` Jason Wang
2018-11-16  2:32           ` jiangyiwen
2018-11-16  6:35             ` Jason Wang
2018-11-15  7:04 ` Michael S. Tsirkin [this message]
2018-11-15  7:38   ` jiangyiwen
2018-11-15  8:10     ` Michael S. Tsirkin
2018-11-15  8:27       ` Jason Wang
2018-11-15  8:38       ` jiangyiwen
2018-11-15  8:24   ` Jason Wang
2018-11-29 14:00     ` Michael S. Tsirkin
2018-11-30 12:45       ` Jason Wang
2018-11-30 12:52         ` Michael S. Tsirkin
2018-11-30 12:55           ` Jason Wang
2018-11-30 13:10             ` Jason Wang
2018-11-30 13:40               ` Michael S. Tsirkin
2018-12-03  3:10                 ` jiangyiwen
2018-12-04  1:31                   ` Michael S. Tsirkin
2018-12-04  2:21                     ` jiangyiwen
2018-12-04  4:08                       ` Michael S. Tsirkin
2018-12-04  6:01                         ` jiangyiwen
2018-11-30 13:34             ` Michael S. Tsirkin
2018-11-15  9:36 ` Yan Vugenfirer
2018-11-16  2:37   ` jiangyiwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115015547-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiangyiwen@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).