From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH net-next 2/7] net: sched: gred: pass extack to nla_parse_nested() Date: Wed, 14 Nov 2018 22:23:46 -0800 Message-ID: <20181115062351.22763-3-jakub.kicinski@netronome.com> References: <20181115062351.22763-1-jakub.kicinski@netronome.com> Cc: netdev@vger.kernel.org, jiri@resnulli.us, xiyou.wangcong@gmail.com, jhs@mojatatu.com, oss-drivers@netronome.com, Jakub Kicinski To: davem@davemloft.net Return-path: Received: from mail-qk1-f196.google.com ([209.85.222.196]:41150 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbeKOQak (ORCPT ); Thu, 15 Nov 2018 11:30:40 -0500 Received: by mail-qk1-f196.google.com with SMTP id 189so30194463qkj.8 for ; Wed, 14 Nov 2018 22:24:09 -0800 (PST) In-Reply-To: <20181115062351.22763-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: In case netlink wants to provide parsing error pass extack to nla_parse_nested(). Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- net/sched/sch_gred.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c index 22110be9d285..9f6a4ddd262a 100644 --- a/net/sched/sch_gred.c +++ b/net/sched/sch_gred.c @@ -406,7 +406,7 @@ static int gred_change(struct Qdisc *sch, struct nlattr *opt, if (opt == NULL) return -EINVAL; - err = nla_parse_nested(tb, TCA_GRED_MAX, opt, gred_policy, NULL); + err = nla_parse_nested(tb, TCA_GRED_MAX, opt, gred_policy, extack); if (err < 0) return err; @@ -476,7 +476,7 @@ static int gred_init(struct Qdisc *sch, struct nlattr *opt, if (!opt) return -EINVAL; - err = nla_parse_nested(tb, TCA_GRED_MAX, opt, gred_policy, NULL); + err = nla_parse_nested(tb, TCA_GRED_MAX, opt, gred_policy, extack); if (err < 0) return err; -- 2.17.1