From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] geneve: Add missing braces in addr6 initializer
Date: Thu, 15 Nov 2018 12:38:45 -0700
Message-ID: <20181115193845.GA22070@flashbox>
References: <20181112221248.11477-1-natechancellor@gmail.com>
 <20181115.113501.2215768757973757171.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: sbrivio@redhat.com, sd@queasysnail.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20181115.113501.2215768757973757171.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Thu, Nov 15, 2018 at 11:35:01AM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Mon, 12 Nov 2018 15:12:48 -0700
> 
> > Clang warns:
> > 
> > drivers/net/geneve.c:428:29: error: suggest braces around initialization
> > of subobject [-Werror,-Wmissing-braces]
> >                 struct in6_addr addr6 = { 0 };
> >                                           ^
> >                                           {}
> > 
> > Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> And this makes GCC warn.
> 
> drivers/net/geneve.c: In function ‘geneve_udp_encap_err_lookup’:
> drivers/net/geneve.c:428:27: warning: missing braces around initializer [-Wmissing-braces]
>    struct in6_addr addr6 = { { 0 } };
>                            ^
>                                { }
> 
> （╯°□°）╯︵ ┻━┻

Yes, sorry, I thought I test built before sending it but apparently not
:( v2 should be sitting in your inbox as a reply to this one unless I
screwed that up too...

Nathan