From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH iproute2 22/22] rdma: make local functions static Date: Thu, 15 Nov 2018 14:36:40 -0800 Message-ID: <20181115223640.411-23-stephen@networkplumber.org> References: <20181115223640.411-1-stephen@networkplumber.org> Cc: Stephen Hemminger To: netdev@vger.kernel.org Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:32832 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389029AbeKPIqs (ORCPT ); Fri, 16 Nov 2018 03:46:48 -0500 Received: by mail-pg1-f193.google.com with SMTP id z11so7021051pgu.0 for ; Thu, 15 Nov 2018 14:37:05 -0800 (PST) In-Reply-To: <20181115223640.411-1-stephen@networkplumber.org> Sender: netdev-owner@vger.kernel.org List-ID: Several functions only used inside utils.c Signed-off-by: Stephen Hemminger --- rdma/rdma.h | 11 ----------- rdma/utils.c | 12 ++++++------ 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/rdma/rdma.h b/rdma/rdma.h index c3b7530b6cc7..05c3c69b07fd 100644 --- a/rdma/rdma.h +++ b/rdma/rdma.h @@ -74,13 +74,6 @@ struct rd_cmd { int (*func)(struct rd *rd); }; -/* - * Parser interface - */ -bool rd_no_arg(struct rd *rd); -void rd_arg_inc(struct rd *rd); - -char *rd_argv(struct rd *rd); /* * Commands interface @@ -95,8 +88,6 @@ void rd_free(struct rd *rd); int rd_set_arg_to_devname(struct rd *rd); int rd_argc(struct rd *rd); -int strcmpx(const char *str1, const char *str2); - /* * Device manipulation */ @@ -117,14 +108,12 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void *data, uint32_t seq); void rd_prepare_msg(struct rd *rd, uint32_t cmd, uint32_t *seq, uint16_t flags); int rd_dev_init_cb(const struct nlmsghdr *nlh, void *data); int rd_attr_cb(const struct nlattr *attr, void *data); -int rd_attr_check(const struct nlattr *attr, int *typep); /* * Print helpers */ void print_driver_table(struct rd *rd, struct nlattr *tb); void newline(struct rd *rd); -void newline_indent(struct rd *rd); #define MAX_LINE_LENGTH 80 #endif /* _RDMA_TOOL_H_ */ diff --git a/rdma/utils.c b/rdma/utils.c index 4840bf226d54..1a0cf56800d4 100644 --- a/rdma/utils.c +++ b/rdma/utils.c @@ -18,14 +18,14 @@ int rd_argc(struct rd *rd) return rd->argc; } -char *rd_argv(struct rd *rd) +static char *rd_argv(struct rd *rd) { if (!rd_argc(rd)) return NULL; return *rd->argv; } -int strcmpx(const char *str1, const char *str2) +static int strcmpx(const char *str1, const char *str2) { if (strlen(str1) > strlen(str2)) return -1; @@ -39,7 +39,7 @@ static bool rd_argv_match(struct rd *rd, const char *pattern) return strcmpx(rd_argv(rd), pattern) == 0; } -void rd_arg_inc(struct rd *rd) +static void rd_arg_inc(struct rd *rd) { if (!rd_argc(rd)) return; @@ -47,7 +47,7 @@ void rd_arg_inc(struct rd *rd) rd->argv++; } -bool rd_no_arg(struct rd *rd) +static bool rd_no_arg(struct rd *rd) { return rd_argc(rd) == 0; } @@ -404,7 +404,7 @@ static const enum mnl_attr_data_type nldev_policy[RDMA_NLDEV_ATTR_MAX] = { [RDMA_NLDEV_ATTR_DRIVER_U64] = MNL_TYPE_U64, }; -int rd_attr_check(const struct nlattr *attr, int *typep) +static int rd_attr_check(const struct nlattr *attr, int *typep) { int type; @@ -696,7 +696,7 @@ void newline(struct rd *rd) pr_out("\n"); } -void newline_indent(struct rd *rd) +static void newline_indent(struct rd *rd) { newline(rd); if (!rd->json_output) -- 2.17.1