From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: lantiq: Fix returned value in case of error in 'xrx200_probe()' Date: Fri, 16 Nov 2018 19:47:39 -0800 (PST) Message-ID: <20181116.194739.1234724172712558692.davem@davemloft.net> References: <20181113174224.7884-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hauke@hauke-m.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: christophe.jaillet@wanadoo.fr Return-path: In-Reply-To: <20181113174224.7884-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Christophe JAILLET Date: Tue, 13 Nov 2018 18:42:24 +0100 > Return 'err' in the error handling path instead of 0. > Return explicitly 0 in the normal path, instead of 'err', which is known > to be 0 at this point. > > Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver") > Signed-off-by: Christophe JAILLET Applied.