From: David Miller <davem@davemloft.net>
To: dwesterg@gmail.com
Cc: netdev@vger.kernel.org, dinguyen@kernel.org,
thor.thayer@linux.intel.com, dalon.westergreen@intel.com
Subject: Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response
Date: Fri, 16 Nov 2018 20:38:00 -0800 (PST) [thread overview]
Message-ID: <20181116.203800.1372283941971325282.davem@davemloft.net> (raw)
In-Reply-To: <20181115005047.28464-2-dwesterg@gmail.com>
From: Dalon Westergreen <dwesterg@gmail.com>
Date: Wed, 14 Nov 2018 16:50:40 -0800
> @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *buffer)
> /* enqueue the request to the pending transmit queue */
> queue_tx(priv, buffer);
>
> - return 1;
> + return 0;
NETDEV_TX_OK.
And now you can make all of these functions properly return netdev_tx_t instead of int.
next prev parent reply other threads:[~2018-11-17 14:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 0:50 [PATCH net-next 0/8] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response Dalon Westergreen
2018-11-15 23:07 ` Thor Thayer
2018-11-17 4:38 ` David Miller [this message]
2018-11-17 15:29 ` Westergreen, Dalon
2018-11-15 0:50 ` [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call Dalon Westergreen
2018-11-15 23:08 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration Dalon Westergreen
2018-11-15 23:10 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma Dalon Westergreen
2018-11-15 23:12 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 5/8] net: eth: altera: tse: Move common functions to altera_utils Dalon Westergreen
2018-11-15 23:14 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping Dalon Westergreen
2018-11-15 3:24 ` Richard Cochran
[not found] ` <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com>
2018-11-16 2:14 ` Richard Cochran
2018-11-16 13:33 ` Dalon Westergreen
2018-11-16 14:48 ` Dalon Westergreen
2018-11-16 18:37 ` Richard Cochran
2018-11-15 0:50 ` [PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher Dalon Westergreen
2018-11-16 15:20 ` Thor Thayer
2018-11-28 0:26 ` Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 8/8] net: eth: altera: tse: update devicetree bindings documentation Dalon Westergreen
2018-11-15 23:49 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116.203800.1372283941971325282.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dalon.westergreen@intel.com \
--cc=dinguyen@kernel.org \
--cc=dwesterg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).