From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response Date: Fri, 16 Nov 2018 20:38:00 -0800 (PST) Message-ID: <20181116.203800.1372283941971325282.davem@davemloft.net> References: <20181115005047.28464-1-dwesterg@gmail.com> <20181115005047.28464-2-dwesterg@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dinguyen@kernel.org, thor.thayer@linux.intel.com, dalon.westergreen@intel.com To: dwesterg@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:49008 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728478AbeKQOxW (ORCPT ); Sat, 17 Nov 2018 09:53:22 -0500 In-Reply-To: <20181115005047.28464-2-dwesterg@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Dalon Westergreen Date: Wed, 14 Nov 2018 16:50:40 -0800 > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *buffer) > /* enqueue the request to the pending transmit queue */ > queue_tx(priv, buffer); > > - return 1; > + return 0; NETDEV_TX_OK. And now you can make all of these functions properly return netdev_tx_t instead of int.