From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, willemb@google.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] udp: fix jump label misuse
Date: Fri, 16 Nov 2018 23:02:22 -0800 (PST) [thread overview]
Message-ID: <20181116.230222.206906047899209462.davem@davemloft.net> (raw)
In-Reply-To: <f26bbd5e7b1a53a0406665089ead9cace940ddc8.1542244924.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Thu, 15 Nov 2018 02:34:50 +0100
> The commit 60fb9567bf30 ("udp: implement complete book-keeping for
> encap_needed") introduced a severe misuse of jump label APIs, which
> syzbot, as reported by Eric, was able to exploit.
>
> When multiple sockets/process can concurrently request (and than
> disable) the udp encap, we need to track the activation counter with
> *_inc()/*_dec() jump label variants, or we can experience bad things
> at disable time.
>
> Fixes: 60fb9567bf30 ("udp: implement complete book-keeping for encap_needed")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks Paolo.
prev parent reply other threads:[~2018-11-17 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 1:34 [PATCH net-next] udp: fix jump label misuse Paolo Abeni
2018-11-17 7:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116.230222.206906047899209462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox