From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual
 queue attributes
Date: Fri, 16 Nov 2018 23:19:43 -0800 (PST)
Message-ID: <20181116.231943.1316025515128598765.davem@davemloft.net>
References: <20181115062351.22763-1-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, jiri@resnulli.us, xiyou.wangcong@gmail.com,
        jhs@mojatatu.com, oss-drivers@netronome.com
To: jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:51178 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725837AbeKQRf3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 17 Nov 2018 12:35:29 -0500
In-Reply-To: <20181115062351.22763-1-jakub.kicinski@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 14 Nov 2018 22:23:44 -0800

> This series updates the GRED Qdisc.  The Qdisc matches nfp offload very
> well, but before we can offload it there are a number of improvements
> to make.
> 
> First few patches add extack messages to the Qdisc and pass extack
> to netlink validation.
> 
> Next a new netlink attribute group is added, to allow GRED to be
> extended more easily.  Currently GRED passes C structures as attributes,
> and even an array of C structs for virtual queue configuration.  User
> space has hard coded the expected length of that array, so adding new
> fields is not possible.
> 
> New two-level attribute group is added:
> 
>   [TCA_GRED_VQ_LIST]
>     [TCA_GRED_VQ_ENTRY]
>       [TCA_GRED_VQ_DP]
>       [TCA_GRED_VQ_FLAGS]
>       [TCA_GRED_VQ_STAT_*]
>     [TCA_GRED_VQ_ENTRY]
>       [TCA_GRED_VQ_DP]
>       [TCA_GRED_VQ_FLAGS]
>       [TCA_GRED_VQ_STAT_*]
>     [TCA_GRED_VQ_ENTRY]
>        ...
> 
> Statistics are dump only. Patch 4 switches the byte counts to be 64 bit,
> and patch 5 introduces the new stats attributes for dump.  Patch 6
> switches RED flags to be per-virtual queue, and patch 7 allows them
> to be dumped and set at virtual queue granularity.

Nice work, series applied.