From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping Date: Thu, 15 Nov 2018 18:14:18 -0800 Message-ID: <20181116021418.dhbw5cu4y56cfjls@localhost> References: <20181115005047.28464-1-dwesterg@gmail.com> <20181115005047.28464-7-dwesterg@gmail.com> <20181115032411.bh6dxqh44iqap4vt@localhost> <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, dinguyen@kernel.org, thor.thayer@linux.intel.com To: Dalon Westergreen Return-path: Received: from mail-pg1-f170.google.com ([209.85.215.170]:46239 "EHLO mail-pg1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbeKPMYt (ORCPT ); Fri, 16 Nov 2018 07:24:49 -0500 Received: by mail-pg1-f170.google.com with SMTP id w7so9859158pgp.13 for ; Thu, 15 Nov 2018 18:14:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > Sure, I would like to keep the debugfs entries for disabling freq correction,and > reading the current scaled_ppm value. I intend to use these to tune anexternal > vcxo. If there is a better way to do this, please let me know. Yes, there is. The external VCXO should be a proper PHC. Then, with a minor change to the linuxptp stack (already in the pipe), you can just use that. You should not disable frequency correction in the driver. Leave that decision to the user space PTP stack. > I would prefer to keep altera just to be consistent with the altera_tse stuff, > and i intend to reusethis code for a 10GbE driver, so perhaps altera_tod to > reference the fpga ip name? So the IP core is called "tod"? Really? Thanks, Richard