From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v6] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs Date: Fri, 16 Nov 2018 08:53:18 +0100 Message-ID: <20181116075318.GF14933@lunn.ch> References: <20181114061703.11026-1-ms@dev.tdt.de> <20181116073836.6013-1-ms@dev.tdt.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: sergei.shtylyov@cogentembedded.com, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Martin Schiller Return-path: Content-Disposition: inline In-Reply-To: <20181116073836.6013-1-ms@dev.tdt.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Nov 16, 2018 at 08:38:36AM +0100, Martin Schiller wrote: > Up until commit 7e5fbd1e0700 ("net: mdio-gpio: Convert to use gpiod > functions where possible"), the _cansleep variants of the gpio_ API was > used. After that commit and the change to gpiod_ API, the _cansleep() > was dropped. This then results in WARN_ON() when used with GPIO > devices which do sleep. Add back the _cansleep() to avoid this. > > Fixes: 7e5fbd1e0700 ("net: mdio-gpio: Convert to use gpiod functions where possible") > Signed-off-by: Martin Schiller Reviewed-by: Andrew Lunn Andrew