From: David Miller <davem@davemloft.net>
To: sunil.kovvuri@gmail.com
Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-soc@vger.kernel.org,
skardach@marvell.com, sgoutham@marvell.com
Subject: Re: [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex
Date: Sat, 17 Nov 2018 11:54:43 -0800 (PST) [thread overview]
Message-ID: <20181117.115443.1924467498930229204.davem@davemloft.net> (raw)
In-Reply-To: <CA+sq2Cfoi50d-yo7YXWZ2CX7EEcYfBoY+DpXek9KLQnjE3z5YQ@mail.gmail.com>
From: Sunil Kovvuri <sunil.kovvuri@gmail.com>
Date: Sat, 17 Nov 2018 21:42:41 +0530
> On Sat, Nov 17, 2018 at 12:50 PM David Miller <davem@davemloft.net> wrote:
>>
>> From: sunil.kovvuri@gmail.com
>> Date: Thu, 15 Nov 2018 16:29:29 +0530
>>
>> > From: Stanislaw Kardach <skardach@marvell.com>
>> >
>> > The resource locks does not need to be a spinlock as they are not
>> > used in any interrupt handling routines (only in bottom halves).
>> > Therefore relax them into a mutex so that later on we may use them
>> > in routines that might sleep.
>> >
>> > Signed-off-by: Stanislaw Kardach <skardach@marvell.com>
>> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
>>
>> This is confusing because software interrupts are often called bottom
>> halves, and in which sleeping and thus mutexes are not allowed.
>
> Mailbox message interrupt handler schedules workqueue and exits.
> Message handling happens in workqueue context, hence moving from
> spinlock to mutex.
> Hope this clarifies.
Fix the commit message like this then.
next prev parent reply other threads:[~2018-11-18 6:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 10:59 [PATCH v2 00/21] octeontx2-af: NPC MCAM support and FLR handling sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 01/21] octeontx2-af: Convert mbox handlers APIs to lowercase sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 02/21] octeontx2-af: Support to modify min/max allowed packet lengths sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 03/21] octeontx2-af: Support to get NIX HW constants from AF sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex sunil.kovvuri
2018-11-17 7:20 ` David Miller
2018-11-17 16:12 ` Sunil Kovvuri
2018-11-17 19:54 ` David Miller [this message]
2018-11-15 10:59 ` [PATCH v2 05/21] octeontx2-af: NPC MCAM entry alloc/free support sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 06/21] octeontx2-af: MCAM entry installation support sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 07/21] octeontx2-af: Support for NPC MCAM counters sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 08/21] octeontx2-af: Map or unmap NPC MCAM entry and counter sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 09/21] octeontx2-af: Alloc and config NPC MCAM entry at a time sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 10/21] octeontx2-af: Add MKEX default profile sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 11/21] octeontx2-af: Support to enable/disable default MCAM entries sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 12/21] octeontx2-af: Add support for stripping STAG/CTAG sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 13/21] octeontx2-af: Verify NPA/SSO/NIX PF_FUNC mapping sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 14/21] octeontx2-af: Add FLR interrupt handler sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 15/21] octeontx2-af: Teardown NPA, NIX LF upon receiving FLR sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 16/21] octeontx2-af: Mbox communication support btw AF and it's VFs sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 17/21] octeontx2-af: Enable sriov on AF to create VFs sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 18/21] octeontx2-af: Configure AF VFs to talk over LBK channels sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 19/21] octeontx2-af: Add FLR handling support for AF's VFs sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 20/21] octeontx2-af: Add interrupt handlers for Master Enable event sunil.kovvuri
2018-11-15 10:59 ` [PATCH v2 21/21] octeontx2-af: Workarounds for HW errata sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117.115443.1924467498930229204.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=linux-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=skardach@marvell.com \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox