From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
tom@herbertland.com, edumazet@google.com
Subject: Re: [Patch net] net: invert the check of detecting hardware RX checksum fault
Date: Sat, 17 Nov 2018 16:40:56 -0800 (PST) [thread overview]
Message-ID: <20181117.164056.1575638266550325370.davem@davemloft.net> (raw)
In-Reply-To: <20181116015242.wmm6mooubjnum7qv@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 16 Nov 2018 09:52:42 +0800
> netdev_rx_csum_fault is meant to warn about the situation where
> a packet with a valid checksum (i.e., sum == 0) was given to us
> by the hardware with a partial checksum that was invalid.
Thanks for reminding us how this code is supposed to work :-)
Definitely we need to better document this and it looks like Cong is
going to add a comment in order to do so.
As for dumping out a packet, we need to rate limit that more strongly
than the existing net_ratelimit() there. But only dumping once per
bootup seems to extreme in the other direction. If we get like 2
or 3 of these in an hour, dumping all of them would be reasonable
and useful.
prev parent reply other threads:[~2018-11-18 10:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 23:16 [Patch net] net: invert the check of detecting hardware RX checksum fault Cong Wang
2018-11-16 1:52 ` Herbert Xu
2018-11-16 2:23 ` Cong Wang
2018-11-16 4:50 ` Herbert Xu
2018-11-16 20:06 ` Cong Wang
2018-11-16 21:32 ` Cong Wang
2018-11-19 4:01 ` Herbert Xu
2018-11-19 19:25 ` Cong Wang
2018-11-20 3:09 ` Herbert Xu
2018-11-22 1:25 ` Paweł Staszewski
2018-11-16 4:52 ` Eric Dumazet
2018-11-16 4:59 ` Herbert Xu
2018-11-16 20:10 ` Cong Wang
2018-11-16 20:15 ` Cong Wang
2018-11-16 21:33 ` Eric Dumazet
2018-11-20 1:42 ` Cong Wang
2018-11-20 1:47 ` Eric Dumazet
2018-11-20 18:13 ` David Miller
2018-11-20 18:18 ` Eric Dumazet
2018-11-21 3:35 ` Herbert Xu
2018-11-18 0:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117.164056.1575638266550325370.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox