From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: lirongqing@baidu.com, netdev@vger.kernel.org
Subject: Re: [PATCH][net-next] net: slightly optimize eth_type_trans
Date: Sat, 17 Nov 2018 16:51:38 -0800 (PST) [thread overview]
Message-ID: <20181117.165138.801331179496411533.davem@davemloft.net> (raw)
In-Reply-To: <d5201107-08b3-8681-993d-2ba3480707e7@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 17 Nov 2018 14:37:12 -0800
>
>
> On 11/15/2018 03:11 PM, David Miller wrote:
>
>>
>> Applied.
>>
>
> While reviewing this stuff, I found we have a bug.
>
> If napi_reuse_skb() is called, we might inherit from prior skb->pkt_type value.
>
> It seems that GRO could aggregate packets with pkt_type != PACKET_HOST, right ?
>
> David, any objection if I submit the following fix ?
Oh weird, so we do GRO frags accumulation using SKB which never goes through
eth_type_trans()?
I don't understand how we can, in this circumstance, assume PACKET_HOST?
Because that is what your suggested patch does.
Frame could be UDP multicast, and we could legitimately GRO accumulate it.
In that situations setting PACKET_HOST doesn't seem correct.
next prev parent reply other threads:[~2018-11-18 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 1:34 [PATCH][net-next] net: slightly optimize eth_type_trans Li RongQing
2018-11-15 23:11 ` David Miller
2018-11-17 22:37 ` Eric Dumazet
2018-11-18 0:51 ` David Miller [this message]
2018-11-18 1:19 ` Eric Dumazet
2018-11-18 4:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117.165138.801331179496411533.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox