From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v4 0/6] net/ncsi: Allow enabling multiple packages & channels Date: Sat, 17 Nov 2018 21:10:06 -0800 (PST) Message-ID: <20181117.211006.376669879094627607.davem@davemloft.net> References: <20181116045159.4980-1-sam@mendozajonas.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Justin.Lee1@Dell.com, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org To: sam@mendozajonas.com Return-path: In-Reply-To: <20181116045159.4980-1-sam@mendozajonas.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Samuel Mendoza-Jonas Date: Fri, 16 Nov 2018 15:51:53 +1100 > This series extends the NCSI driver to configure multiple packages > and/or channels simultaneously. Since the RFC series this includes a few > extra changes to fix areas in the driver that either made this harder or > were roadblocks due to deviations from the NCSI specification. > > Patches 1 & 2 fix two issues where the driver made assumptions about the > capabilities of the NCSI topology. > Patches 3 & 4 change some internal semantics slightly to make multi-mode > easier. > Patch 5 introduces a cleaner way of reconfiguring the NCSI configuration > and keeping track of channel states. > Patch 6 implements the main multi-package/multi-channel configuration, > configured via the Netlink interface. > > Readers who have an interesting NCSI setup - especially multi-package > with HWA - please test! I think I've covered all permutations but I > don't have infinite hardware to test on. > > Changes in v2: > - Updated use of the channel lock in ncsi_reset_dev(), making the > channel invisible and leaving the monitor check to > ncsi_stop_channel_monitor(). > - Fixed ncsi_channel_is_tx() to consider the state of channels in other > packages. > Changes in v3: > - Fixed bisectability bug in patch 1 > - Consider channels on all packages in a few places when multi-package > is enabled. > - Avoid doubling up reset operations, and check the current driver state > before reset to let any running operations complete. > - Reorganise the LSC handler slightly to avoid enabling Tx twice. > Changes in v4: > - Fix failover in the single-channel case > - Better handle ncsi_reset_dev() entry during a current config/suspend > operation. Series applied.