From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net 1/1] tipc: fix lockdep warning when reinitilaizing sockets Date: Sat, 17 Nov 2018 22:02:22 -0800 (PST) Message-ID: <20181117.220222.855143290565890167.davem@davemloft.net> References: <1542405304-17254-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, gordan.mihaljevic@dektech.com.au, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, jon.maloy@ericsson.com, maloy@donjonn.com, xinl@redhat.com, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net To: donmalo99@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:42190 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbeKRQVk (ORCPT ); Sun, 18 Nov 2018 11:21:40 -0500 In-Reply-To: <1542405304-17254-1-git-send-email-jon.maloy@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jon Maloy Date: Fri, 16 Nov 2018 16:55:04 -0500 > We get the following warning: ... > The reason seems to be that tipc_net_finalize()->tipc_sk_reinit() is > calling the function rhashtable_walk_enter() within a timer interrupt. > We fix this by executing tipc_net_finalize() in work queue context. > > Acked-by: Ying Xue > Signed-off-by: Jon Maloy Applied and queued up for -stable.