From: Andrew Lunn <andrew@lunn.ch>
To: David Ahern <dsahern@gmail.com>
Cc: "Md. Islam" <mislam4@kent.edu>, Netdev <netdev@vger.kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
john fastabend <john.fastabend@gmail.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH RFC net-next] net: SAIL based FIB lookup for XDP
Date: Sun, 18 Nov 2018 18:52:53 +0100 [thread overview]
Message-ID: <20181118175253.GB7446@lunn.ch> (raw)
In-Reply-To: <f427155e-685c-adb6-1a2e-c78b9f1511f6@gmail.com>
> > + * The router can have upto 255 ports. This limitation
> > + * allows us to represent netdev_index as an u8
> > + */
> > +#define NETDEV_COUNT_MAX 255
>
> ... 255 is high for a physical port count but not a logical device
> count. In the presence of VLANs 255 is nothing and VLANs are an
> essential deployment feature.
I agree with David here. Doing some network simulation work using
namespaces, i've had more than 255 devices in the root namespace.
Andrew
next prev parent reply other threads:[~2018-11-19 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 2:25 [PATCH RFC net-next] net: SAIL based FIB lookup for XDP Md. Islam
2018-11-18 17:42 ` David Ahern
2018-11-18 17:52 ` Andrew Lunn [this message]
[not found] ` <CAFgPn1CZSico0uCwaFPS9VGm7aQiY68Y3U+hdkJO_pSu8A1soQ@mail.gmail.com>
2018-11-20 5:30 ` Fwd: " Md. Islam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118175253.GB7446@lunn.ch \
--to=andrew@lunn.ch \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mislam4@kent.edu \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox