From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend
Date: Mon, 19 Nov 2018 18:43:43 -0800 (PST)
Message-ID: <20181119.184343.1334940445389777881.davem@davemloft.net>
References: <1542650162-9229-1-git-send-email-opendmb@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, yuehaibing@huawei.com
To: opendmb@gmail.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1542650162-9229-1-git-send-email-opendmb@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Doug Berger <opendmb@gmail.com>
Date: Mon, 19 Nov 2018 09:56:00 -0800

> It is not enough to return an error code from the driver suspend
> routine. The driver must also restore the device functionality.
> 
> This commit corrects the issue introduced by commit 0db55093b566 
> ("net: bcmgenet: return correct value 'ret' from bcmgenet_power_down")
> by calling the driver resume function if the suspend function returns
> an error.
> 
> Changes in v2:
> - Removed accidentally included write to HFB register

Doug, this doesn't apply cleanly to net-next.