From: Stephen Hemminger <stephen@networkplumber.org>
To: yupeng <yupeng0921@gmail.com>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, rdunlap@infradead.org
Subject: Re: [PATCH net-next] add part of TCP counts explanations in snmp_counters.rst
Date: Mon, 19 Nov 2018 10:51:28 -0800 [thread overview]
Message-ID: <20181119105128.56356687@xeon-e3> (raw)
In-Reply-To: <20181116191740.12632-1-yupeng0921@gmail.com>
On Fri, 16 Nov 2018 11:17:40 -0800
yupeng <yupeng0921@gmail.com> wrote:
> +* TcpInSegs
> +Defined in `RFC1213 tcpInSegs`_
> +
> +.. _RFC1213 tcpInSegs: https://tools.ietf.org/html/rfc1213#page-48
> +
> +The number of packets received by the TCP layer. As mentioned in
> +RFC1213, it includes the packets received in error, such as checksum
> +error, invalid TCP header and so on. Only one error won't be included:
> +if the layer 2 destination address is not the NIC's layer 2
> +address. It might happen if the packet is a multicast or broadcast
> +packet, or the NIC is in promiscuous mode. In these situations, the
> +packets would be delivered to the TCP layer, but the TCP layer will discard
> +these packets before increasing TcpInSegs. The TcpInSegs counter
> +isn't aware of GRO. So if two packets are merged by GRO, the TcpInSegs
> +counter would only increase 1.
Is it it obvious that TCP which is L4 masks off all the other things
that could happen at L3 and L2. SO this text is correct but redundant.
next prev parent reply other threads:[~2018-11-20 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 19:17 [PATCH net-next] add part of TCP counts explanations in snmp_counters.rst yupeng
2018-11-18 20:57 ` David Miller
2018-11-19 18:51 ` Stephen Hemminger [this message]
2018-11-20 3:10 ` peng yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119105128.56356687@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yupeng0921@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).