From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action
 representation
Date: Mon, 19 Nov 2018 13:37:07 +0100
Message-ID: <20181119123707.4ezxkgabjeccidmd@salvia>
References: <20181119001519.12124-1-pablo@netfilter.org>
 <20181119001519.12124-5-pablo@netfilter.org>
 <20181119121630.GD2223@nanopsycho.orion>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        thomas.lendacky@amd.com, f.fainelli@gmail.com,
        ariel.elior@cavium.com, michael.chan@broadcom.com,
        santosh@chelsio.com, madalin.bucur@nxp.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        jeffrey.t.kirsher@intel.com, tariqt@mellanox.com,
        saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com,
        jakub.kicinski@netronome.com, peppe.cavallaro@st.com,
        grygorii.strashko@ti.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, linux-net-drivers@solarflare.com,
        ganeshgr@chelsio.com, ogerlitz@mellanox.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.us.es ([193.147.175.20]:47024 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728724AbeKSXAn (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 19 Nov 2018 18:00:43 -0500
Received: from antivirus1-rhel7.int (unknown [192.168.2.11])
        by mail.us.es (Postfix) with ESMTP id 96C55E1221
        for <netdev@vger.kernel.org>; Mon, 19 Nov 2018 13:37:11 +0100 (CET)
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id 84210DA56C
        for <netdev@vger.kernel.org>; Mon, 19 Nov 2018 13:37:11 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20181119121630.GD2223@nanopsycho.orion>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Nov 19, 2018 at 01:16:30PM +0100, Jiri Pirko wrote:
> >@@ -391,18 +392,27 @@ static int fl_hw_replace_filter(struct tcf_proto *tp,
> > 	cls_flower.exts = &f->exts;
> > 	cls_flower.classid = f->res.classid;
> > 
> >+	if (tc_setup_flow_action(&f->action, &f->exts) < 0)
> >+		return -ENOMEM;
> >+
> >+	cls_flower.rule.action.keys = f->action.keys;
> >+	cls_flower.rule.action.num_keys = f->action.num_keys;
> 
> Hmm, I think flow actions should be only field in rule. Flower does not
> use it internally, so it does not really make sense to have f->action

OK, will remove this new field from flower.

Thanks!