Re: [PATCH net-next,v2 08/12] flow_dissector: add wake-up-on-lan and queue to flow_action

Jiri Pirko
2018-11-20T00:30:19Z

Mon, Nov 19, 2018 at 01:15:15AM CET, pablo@netfilter.org wrote:
>These actions need to be added to support bcm sf2 features available
>through the ethtool_rx_flow interface.
>
>Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

For me it would be nicer to have this as 2 patches, one per action type.
But up to you.

>---
>v2: no changes.
>
> include/net/flow_dissector.h | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
>index 925c208816f1..7a4683646d5a 100644
>--- a/include/net/flow_dissector.h
>+++ b/include/net/flow_dissector.h
>@@ -418,6 +418,8 @@ enum flow_action_key_id {
> FLOW_ACTION_KEY_ADD,
> FLOW_ACTION_KEY_CSUM,
> FLOW_ACTION_KEY_MARK,
>+ FLOW_ACTION_KEY_WAKE,
>+ FLOW_ACTION_KEY_QUEUE,
> };
>
> /* This is mirroring enum pedit_header_type definition for easy mapping between
>@@ -452,6 +454,7 @@ struct flow_action_key {
> const struct ip_tunnel_info *tunnel; /* FLOW_ACTION_KEY_TUNNEL_ENCAP */
> u32 csum_flags; /* FLOW_ACTION_KEY_CSUM */
> u32 mark; /* FLOW_ACTION_KEY_MARK */
>+ u32 queue_index; /* FLOW_ACTION_KEY_QUEUE */
> };
> };
>
>--
>2.11.0
>