From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next,v2 08/12] flow_dissector: add wake-up-on-lan and queue to flow_action Date: Mon, 19 Nov 2018 14:59:55 +0100 Message-ID: <20181119135955.GH2223@nanopsycho.orion> References: <20181119001519.12124-1-pablo@netfilter.org> <20181119001519.12124-9-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com To: Pablo Neira Ayuso Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:41239 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729494AbeKTAaT (ORCPT ); Mon, 19 Nov 2018 19:30:19 -0500 Received: by mail-wr1-f67.google.com with SMTP id x10so3552997wrs.8 for ; Mon, 19 Nov 2018 06:06:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181119001519.12124-9-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Nov 19, 2018 at 01:15:15AM CET, pablo@netfilter.org wrote: >These actions need to be added to support bcm sf2 features available >through the ethtool_rx_flow interface. > >Reviewed-by: Florian Fainelli >Signed-off-by: Pablo Neira Ayuso For me it would be nicer to have this as 2 patches, one per action type. But up to you. >--- >v2: no changes. > > include/net/flow_dissector.h | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h >index 925c208816f1..7a4683646d5a 100644 >--- a/include/net/flow_dissector.h >+++ b/include/net/flow_dissector.h >@@ -418,6 +418,8 @@ enum flow_action_key_id { > FLOW_ACTION_KEY_ADD, > FLOW_ACTION_KEY_CSUM, > FLOW_ACTION_KEY_MARK, >+ FLOW_ACTION_KEY_WAKE, >+ FLOW_ACTION_KEY_QUEUE, > }; > > /* This is mirroring enum pedit_header_type definition for easy mapping between >@@ -452,6 +454,7 @@ struct flow_action_key { > const struct ip_tunnel_info *tunnel; /* FLOW_ACTION_KEY_TUNNEL_ENCAP */ > u32 csum_flags; /* FLOW_ACTION_KEY_CSUM */ > u32 mark; /* FLOW_ACTION_KEY_MARK */ >+ u32 queue_index; /* FLOW_ACTION_KEY_QUEUE */ > }; > }; > >-- >2.11.0 >