From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net-next,v2 09/12] flow_dissector: add basic ethtool_rx_flow_spec to flow_rule structure translator Date: Mon, 19 Nov 2018 15:43:44 +0100 Message-ID: <20181119144344.ydar4ks7rk7jp2ej@salvia> References: <20181119001519.12124-1-pablo@netfilter.org> <20181119001519.12124-10-pablo@netfilter.org> <20181119141743.GJ2223@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com To: Jiri Pirko Return-path: Received: from mail.us.es ([193.147.175.20]:36912 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727419AbeKTBHh (ORCPT ); Mon, 19 Nov 2018 20:07:37 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4C3C7114818 for ; Mon, 19 Nov 2018 15:43:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3D614DA56B for ; Mon, 19 Nov 2018 15:43:47 +0100 (CET) Content-Disposition: inline In-Reply-To: <20181119141743.GJ2223@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Nov 19, 2018 at 03:17:43PM +0100, Jiri Pirko wrote: > Mon, Nov 19, 2018 at 01:15:16AM CET, pablo@netfilter.org wrote: [...] > >diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h > >index 7a4683646d5a..ec9036232538 100644 > >--- a/include/net/flow_dissector.h > >+++ b/include/net/flow_dissector.h [...] > >+struct flow_rule *ethtool_rx_flow_rule(const struct ethtool_rx_flow_spec *fs) [...] > Code that is doing ethtool->flow_rule conversion should be in ethtool > code. You should just provide helpers here (in flow.c) that could be > used to assemble the flow_rule structure. OK, will place this in ethtool file.