From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH iproute2-next 2/8] json: add %hhu helpers Date: Mon, 19 Nov 2018 17:40:18 -0800 Message-ID: <20181119174018.0629445a@cakuba.netronome.com> References: <20181119230335.11771-1-jakub.kicinski@netronome.com> <20181119230335.11771-3-jakub.kicinski@netronome.com> <20181119171842.1d1e94ad@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dsahern@gmail.com, oss-drivers@netronome.com, netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-qk1-f196.google.com ([209.85.222.196]:33958 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727679AbeKTMG6 (ORCPT ); Tue, 20 Nov 2018 07:06:58 -0500 Received: by mail-qk1-f196.google.com with SMTP id a132so499228qkg.1 for ; Mon, 19 Nov 2018 17:40:23 -0800 (PST) In-Reply-To: <20181119171842.1d1e94ad@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 19 Nov 2018 17:18:42 -0800, Stephen Hemminger wrote: > > void jsonw_hu_field(json_writer_t *self, const char *prop, unsigned short num) > > { > > jsonw_name(self, prop); > > Do you really need this? it turns out that because of C type > conversions print_uint should just work? I wondered about that for a second, but I took the existence of jsonw_hu_field() etc. as a proof that explicit typing is preferred.