From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH iproute2-next 1/8] tc: gred: remove unclear comment Date: Mon, 19 Nov 2018 15:03:28 -0800 Message-ID: <20181119230335.11771-2-jakub.kicinski@netronome.com> References: <20181119230335.11771-1-jakub.kicinski@netronome.com> Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, Jakub Kicinski To: dsahern@gmail.com, stephen@networkplumber.org Return-path: Received: from mail-qk1-f194.google.com ([209.85.222.194]:34524 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731164AbeKTJ3q (ORCPT ); Tue, 20 Nov 2018 04:29:46 -0500 Received: by mail-qk1-f194.google.com with SMTP id a132so18588qkg.1 for ; Mon, 19 Nov 2018 15:03:48 -0800 (PST) In-Reply-To: <20181119230335.11771-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: The comment about providing a proper message seems similar to the comment in the kernel which says: /* hack -- fix at some point with proper message This is how we indicate to tc that there is no VQ at this DP */ it's unclear what that message would be, and whether it's needed. Remove the confusing comment. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tc/q_gred.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tc/q_gred.c b/tc/q_gred.c index e63fac72a883..80a9ccbbd3cb 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -302,8 +302,6 @@ static int gred_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) return -1; } -/* Bad hack! should really return a proper message as shown above*/ - fprintf(f, "vqs %u default %u %s", sopt->DPs, sopt->def_DP, -- 2.17.1