From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 00/12 net-next,v2] add flow_rule infrastructure Date: Tue, 20 Nov 2018 09:16:40 -0800 (PST) Message-ID: <20181120.091640.1759508282843765424.davem@davemloft.net> References: <20181119001519.12124-1-pablo@netfilter.org> <20181119.121229.2109900411029672811.davem@davemloft.net> <20181120073912.GA2264@nanopsycho> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pablo@netfilter.org, netdev@vger.kernel.org, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43278 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726975AbeKUDq5 (ORCPT ); Tue, 20 Nov 2018 22:46:57 -0500 In-Reply-To: <20181120073912.GA2264@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Tue, 20 Nov 2018 08:39:12 +0100 > If later on the netfilter code will use it, through another > ndo/notifier/whatever, that is side a nice side-effect in my > opinion. Netfilter HW offloading is the main motivation of these changes. You can try to spin it any way you like, but I think this is pretty clear. Would the author of these changes be even be remotely interested in this "cleanup" in areas of code he has never been involved in if that were not the case? I think it is very dishonest to portray the situation differently. Thank you.