From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] tcp: drop dst in tcp_add_backlog()
Date: Tue, 20 Nov 2018 10:26:10 -0800 (PST)
Message-ID: <20181120.102610.679905109392985656.davem@davemloft.net>
References: <CANn89iKubtjj-a8TNYHyVU=Xv24eqriQkV=sE6TCgqbjYYVr_w@mail.gmail.com>
        <20181120.101638.365512079157603391.davem@davemloft.net>
        <CANn89i+ZMuSm9mEy101wuxWBgnd64nXh7fgoYq-TTTU7RwPPSQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
To: edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:44648 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725926AbeKUE4l (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Nov 2018 23:56:41 -0500
In-Reply-To: <CANn89i+ZMuSm9mEy101wuxWBgnd64nXh7fgoYq-TTTU7RwPPSQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <edumazet@google.com>
Date: Tue, 20 Nov 2018 10:21:22 -0800

> On Tue, Nov 20, 2018 at 10:16 AM David Miller <davem@davemloft.net> wrote:
>>
>> Well, I'm sure we "handle" it.  But I was more asking about the performance
>> tradeoff, which probably is on the side of your change but I wanted to
>> just be sure.
> 
> Ah sorry for misunderstanding.
> Yes, that should be fine, backlog is not generally used at the
> beginning of a flow.
> 
> I am working on adding coalescing support to tcp_add_backlog() to balance
> time spent in softirq and time spent from process context, hoping to reduce
> probability of having user threads trapped for a while in __release_sock()

Ok, meanwhile I applied the patch under discussion.

Thanks.