From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH 00/12 net-next,v2] add flow_rule infrastructure Date: Tue, 20 Nov 2018 08:39:12 +0100 Message-ID: <20181120073912.GA2264@nanopsycho> References: <20181119001519.12124-1-pablo@netfilter.org> <20181119.121229.2109900411029672811.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pablo@netfilter.org, netdev@vger.kernel.org, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com To: David Miller Return-path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:38341 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbeKTSNi (ORCPT ); Tue, 20 Nov 2018 13:13:38 -0500 Received: by mail-wm1-f67.google.com with SMTP id k198so1114690wmd.3 for ; Mon, 19 Nov 2018 23:45:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181119.121229.2109900411029672811.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Nov 19, 2018 at 09:12:29PM CET, davem@davemloft.net wrote: >From: Pablo Neira Ayuso >Date: Mon, 19 Nov 2018 01:15:07 +0100 > >> This patchset introduces a kernel intermediate representation (IR) to >> express ACL hardware offloads, as already described in previous RFC and >> v1 patchset [1] [2]. The idea is to normalize the frontend U/APIs to use >> the flow dissectors and the flow actions so drivers can reuse the >> existing TC offload driver codebase - that has been converted to use the >> flow_rule infrastructure. > >I'm go to bring up the elephant in the room. > >I think the real motivation here is to offload netfilter rules to HW, >and you should be completely honest about that. Sure, but this patchset is mainly about making the parsing code in drivers common no matter from where the "flow rule" comes. If later on the netfilter code will use it, through another ndo/notifier/whatever, that is side a nice side-effect in my opinion.