* [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing
@ 2018-11-20 8:15 Stephen Mallon
2018-11-20 17:50 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Mallon @ 2018-11-20 8:15 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David S. Miller, netdev, stephen.mallon
During tcp coalescing ensure that the skb hardware timestamp refers to the
highest sequence number data.
Previously only the software timestamp was updated during coalescing.
Signed-off-by: Stephen Mallon <stephen.mallon@sydney.edu.au>
---
net/ipv4/tcp_input.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 2868ef28ce52..e695584bb33f 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -4363,6 +4363,7 @@ static bool tcp_try_coalesce(struct sock *sk,
if (TCP_SKB_CB(from)->has_rxtstamp) {
TCP_SKB_CB(to)->has_rxtstamp = true;
to->tstamp = from->tstamp;
+ skb_hwtstamps(to)->hwtstamp = skb_hwtstamps(from)->hwtstamp;
}
return true;
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing
2018-11-20 8:15 [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing Stephen Mallon
@ 2018-11-20 17:50 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2018-11-20 17:50 UTC (permalink / raw)
To: Stephen Mallon, Eric Dumazet; +Cc: David S. Miller, netdev
On 11/20/2018 12:15 AM, Stephen Mallon wrote:
> During tcp coalescing ensure that the skb hardware timestamp refers to the
> highest sequence number data.
> Previously only the software timestamp was updated during coalescing.
>
> Signed-off-by: Stephen Mallon <stephen.mallon@sydney.edu.au>
> ---
> net/ipv4/tcp_input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 2868ef28ce52..e695584bb33f 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -4363,6 +4363,7 @@ static bool tcp_try_coalesce(struct sock *sk,
> if (TCP_SKB_CB(from)->has_rxtstamp) {
> TCP_SKB_CB(to)->has_rxtstamp = true;
> to->tstamp = from->tstamp;
> + skb_hwtstamps(to)->hwtstamp = skb_hwtstamps(from)->hwtstamp;
> }
>
> return true;
>
SGTM, thanks !
Signed-off-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-21 4:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 8:15 [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing Stephen Mallon
2018-11-20 17:50 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).