From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Balaev <mail@void.so>
Subject: Re: [PATCH v2] ipv4: make DSCP values works with ip rules
Date: Tue, 20 Nov 2018 17:36:25 +0300
Message-ID: <20181120143624.GA6920@rnd.infotecs.ru>
References: <20181120132927.GA4987@rnd.infotecs.ru>
 <20181120141218.GA3474@bistromath.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: netdev@vger.kernel.org
To: Sabrina Dubroca <sd@queasysnail.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from forward106j.mail.yandex.net ([5.45.198.249]:53495 "EHLO
        forward106j.mail.yandex.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726040AbeKUBGr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Nov 2018 20:06:47 -0500
Content-Disposition: inline
In-Reply-To: <20181120141218.GA3474@bistromath.localdomain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Nov 20, 2018 at 03:12:18PM +0100, Sabrina Dubroca wrote:
> Hi Pavel,
> 
> 2018-11-20, 16:29:36 +0300, Pavel Balaev wrote:
> > This patch adds ability to set DSCP values in ip rules.
> 
> You dropped the RFC reference that you had in v1.
> 
RFC2474 and RFC2597 values.
> > Values presented in /etc/iproute3/rt_dsfield and now can be used in rules.
> 
> iproute3?
> 
That was a typo, iproute2.
> > 
> > Example:
> > $ ip ru add from 10.88.0.2 tos AF23 lookup dscp.
> > Result:
> > ---
> 
> Be careful when you write commit messages. "git am" is going to cut
> out everything that comes after the first ^---$ line it sees, so the
> rest of those explanations, as well as your sign-off, will be dropped.
> 
> > 32762:	from 10.88.0.2 tos AF43 lookup dscp
> > ---
> > 
> > Patch was tested with such configuration:
> > 
> > +-----------+
> > | 10.88.0.2 | -> ping 172.16.0.1 -Q 0x58 ->
> > |   host0   |
> > +-----------+
> > 
> >    +-------------------------------------+
> >    | router with patched kernel          |
> >    |                                     |
> > -> | from 10.88.0.2 tos AF43 lookup dscp |->
> >    | table dscp:                         |
> >    |   172.16.0.0/24 via 10.200.0.2      |
> >    +-------------------------------------+
> > 
> > 	 +------------------+
> > -> | eth0: 10.200.0.2 |
> >    | eth1: 172.16.0.1 |
> >    |      host1       |
> >    +------------------+
> > 
> > Signed-off-by: Pavel Balaev <mail@void.so>
> 
> -- 
> Sabrina
Ok. Got it. Tnx.