From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v1 net] lan743x: fix return value for lan743x_tx_napi_poll
Date: Tue, 20 Nov 2018 20:30:54 +0100
Message-ID: <20181120193054.GE2649@lunn.ch>
References: <1542738403-23034-1-git-send-email-Bryan.Whitehead@microchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        UNGLinuxDriver@microchip.com
To: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:43033 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726054AbeKUGBm (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 21 Nov 2018 01:01:42 -0500
Content-Disposition: inline
In-Reply-To: <1542738403-23034-1-git-send-email-Bryan.Whitehead@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Nov 20, 2018 at 01:26:43PM -0500, Bryan Whitehead wrote:
> It has been noticed that under stress the lan743x driver will
> sometimes hang or cause a kernel panic. It has been noticed
> that returning '0' instead of 'weight' fixes this issue.
> 
> fixes: rare kernel panic under heavy traffic load.
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com>

Hi Bryan

This sounds like a band aid over something which is broken, not a real
fix.

Can you show us the stack trace from the panic?

    Andrew