From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: netdev@vger.kernel.org, sgoutham@cavium.com
Subject: Re: net: thunderx: nicvf_xdp_setup error code path
Date: Wed, 21 Nov 2018 16:18:46 -0800 (PST) [thread overview]
Message-ID: <20181121.161846.32682644237371562.davem@davemloft.net> (raw)
In-Reply-To: <20181120175635.GA21691@localhost.localdomain>
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Tue, 20 Nov 2018 18:56:36 +0100
> Hi all,
>
> looking at thunderx XDP support I noticed that nic->xdp_prog pointer in
> nicvf_xdp_setup is not actually set to NULL if bpf_prog_add fails but it
> is initialized with bpf_prog_add error code. xdp_prog pointer value is used in
> the driver to verify if XDP is currently enabled.
> Moreover nicvf_xdp_setup does not report to the userspace any error code in
> case of failure.
> I wrote the following patch to fix the reported issues. Please note I just
> compiled it, not actually tested since I have no thunderx nic at the moment.
>
> @Sunil: could you please give it a whirl? If it is ok I will post a formal
> patch, thanks
Sunil did review this, so please resubmit formally.
next prev parent reply other threads:[~2018-11-22 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 17:56 net: thunderx: nicvf_xdp_setup error code path Lorenzo Bianconi
2018-11-21 4:43 ` Goutham, Sunil
2018-11-22 0:18 ` David Miller [this message]
2018-11-22 9:11 ` net: " Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121.161846.32682644237371562.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).