From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Chen Subject: Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts Date: Wed, 21 Nov 2018 08:49:03 +0800 Message-ID: <20181121004903.GA28845@andestech.com> References: <1542692266-17720-1-git-send-email-vincentc@andestech.com> <20181120.102843.2033247081781930217.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "gregkh@linuxfoundation.org" , "rdunlap@infradead.org" , "yuehaibing@huawei.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20181120.102843.2033247081781930217.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Nov 21, 2018 at 02:28:43AM +0800, David Miller wrote: > aFrom: Vincent Chen > Date: Tue, 20 Nov 2018 13:37:46 +0800 > > > + /* Disable interrupts for polling */ > > + ftmac100_disable_all_int(priv); > > if (likely(netif_running(netdev))) { > > - /* Disable interrupts for polling */ > > - ftmac100_disable_all_int(priv); > > napi_schedule(&priv->napi); > > } > > This is now a single-line basic block, so please remove the curly > braces. > > Thank you. OK. I will remove it. Thank you.