From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] ipnetns: parse nsid as a signed integer
Date: Wed, 21 Nov 2018 09:37:42 -0800
Message-ID: <20181121093742.47755677@xeon-e3>
References: <3df598c0-d90a-c794-e19b-22e0f61d4f49@gmail.com>
        <20181121094427.19007-1-nicolas.dichtel@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, dsahern@gmail.com, joe@wand.net.nz,
        daniel@iogearbox.net
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f196.google.com ([209.85.214.196]:34465 "EHLO
        mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727787AbeKVENE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Nov 2018 23:13:04 -0500
Received: by mail-pl1-f196.google.com with SMTP id f12-v6so6491484plo.1
        for <netdev@vger.kernel.org>; Wed, 21 Nov 2018 09:37:46 -0800 (PST)
In-Reply-To: <20181121094427.19007-1-nicolas.dichtel@6wind.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 21 Nov 2018 10:44:27 +0100
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:

> Don't confuse the user, nsid is a signed integer, this kind of command
> should return an error: 'ip netns set foo 0xffffffff'.
> 
> Also, a valid value is a positive value. To let the kernel chooses a value,
> the keyword 'auto' must be used.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Thanks for catching this. Next time add a Fixes: tag if possible.

Applied.