From: David Miller <davem@davemloft.net>
To: Igor.Russkikh@aquantia.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
andrew@lunn.ch, Dmitry.Bezrukov@aquantia.com
Subject: Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO
Date: Thu, 22 Nov 2018 11:17:21 -0800 (PST) [thread overview]
Message-ID: <20181122.111721.914381831657210253.davem@davemloft.net> (raw)
In-Reply-To: <913d4885a93b10a9ff4d8f1de318cefa54c803e6.1542794577.git.igor.russkikh@aquantia.com>
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
Date: Wed, 21 Nov 2018 10:13:48 +0000
> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
> /*Length of actual data*/
> tx_desc |= skb->len & AQ_TX_DESC_LEN_MASK;
>
> + /* TSO MSS */
> + tx_desc |= ((u64)(skb_shinfo(skb)->gso_size & AQ_TX_DESC_MSS_MASK)) <<
> + AQ_TX_DESC_MSS_SHIFT;
...
> +#define AQ_TX_DESC_MSS_MASK 0x7FFF
This implies a GSO size limit, which you need to advertise properly in
netdevice->gso_max_size.
Also, where is the TSO feature flag being set to actually enable the
stack sending your GSO frames?
next prev parent reply other threads:[~2018-11-23 5:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 10:13 [PATCH v3 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 04/21] net: usb: aqc111: Various callbacks implementation Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 05/21] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 06/21] net: usb: aqc111: Introduce link management Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address Igor Russkikh
2020-11-05 3:13 ` Anant Thazhemadam
2020-11-12 7:31 ` [EXT] " Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 08/21] net: usb: aqc111: Implement TX data path Igor Russkikh
2018-11-22 19:07 ` David Miller
2018-11-21 10:13 ` [PATCH v3 net-next 09/21] net: usb: aqc111: Implement RX " Igor Russkikh
2018-11-22 19:12 ` David Miller
2018-11-21 10:13 ` [PATCH v3 net-next 10/21] net: usb: aqc111: Add checksum offload support Igor Russkikh
2018-11-22 19:14 ` David Miller
2018-11-21 10:13 ` [PATCH v3 net-next 11/21] net: usb: aqc111: Add support for changing MTU Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO Igor Russkikh
2018-11-22 19:17 ` David Miller [this message]
2018-11-23 8:58 ` Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support Igor Russkikh
2018-11-21 10:13 ` [PATCH v3 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure Igor Russkikh
2018-11-21 10:14 ` [PATCH v3 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks Igor Russkikh
2018-11-21 10:14 ` [PATCH v3 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Igor Russkikh
2018-11-21 10:14 ` [PATCH v3 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids Igor Russkikh
2018-11-21 10:14 ` [PATCH v3 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122.111721.914381831657210253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=andrew@lunn.ch \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).