From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: richardcochran@gmail.com, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in ptp_clock_register
Date: Fri, 23 Nov 2018 18:04:21 -0800 (PST) [thread overview]
Message-ID: <20181123.180421.2263933715335445413.davem@davemloft.net> (raw)
In-Reply-To: <20181123015455.24228-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 23 Nov 2018 09:54:55 +0800
> Fix smatch warning:
>
> drivers/ptp/ptp_clock.c:298 ptp_clock_register() warn:
> passing zero to 'ERR_PTR'
>
> 'err' should be set while device_create_with_groups and
> pps_register_source fails
>
> Fixes: 85a66e550195 ("ptp: create "pins" together with the rest of attributes")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
prev parent reply other threads:[~2018-11-24 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 1:54 [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in ptp_clock_register YueHaibing
2018-11-23 16:37 ` Richard Cochran
2018-11-26 10:20 ` YueHaibing
2018-11-24 2:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123.180421.2263933715335445413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).