From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd_queue Date: Fri, 23 Nov 2018 22:33:34 -0800 (PST) Message-ID: <20181123.223334.1969691917725314747.davem@davemloft.net> References: <6334938109def4dc5ead5ff1ae66e2d37c9bc595.1542993848.git.lorenzo.bianconi@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Sunil.Goutham@cavium.com To: lorenzo.bianconi@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:42844 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730842AbeKXRUu (ORCPT ); Sat, 24 Nov 2018 12:20:50 -0500 In-Reply-To: <6334938109def4dc5ead5ff1ae66e2d37c9bc595.1542993848.git.lorenzo.bianconi@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Lorenzo Bianconi Date: Fri, 23 Nov 2018 18:28:01 +0100 > Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine > since it is used to check if tso dma descriptor queue has been previously > allocated. The issue can be triggered with the following reproducer: > > $ip link set dev enP2p1s0v0 xdpdrv obj xdp_dummy.o > $ip link set dev enP2p1s0v0 xdpdrv off ... > where xdp_dummy.c is a simple bpf program that forwards the incoming > frames to the network stack (available here: > https://github.com/altoor/xdp_walkthrough_examples/blob/master/sample_1/xdp_dummy.c) > > Fixes: 05c773f52b96 ("net: thunderx: Add basic XDP support") > Fixes: 4863dea3fab0 ("net: Adding support for Cavium ThunderX network > controller") > > Signed-off-by: Lorenzo Bianconi Applied and queued up for -stable, but please in the future: 1) Do not break up long "Fixes: " tag lines, it must be keep as a single uninterrupted line for grep'ability etc. 2) Do not put an empty line between "Fixes: " and other tags. All tags are equal, and appear in a straight uninterrupted sequence of lines. Thank you.