From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in
 ptp_clock_register
Date: Fri, 23 Nov 2018 08:37:14 -0800
Message-ID: <20181123163714.rxp766mx63bnx4tb@localhost>
References: <20181123015455.24228-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, dmitry.torokhov@gmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
To: YueHaibing <yuehaibing@huawei.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20181123015455.24228-1-yuehaibing@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Fri, Nov 23, 2018 at 09:54:55AM +0800, YueHaibing wrote:
> @@ -264,6 +266,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>  		pps.owner = info->owner;
>  		ptp->pps_source = pps_register_source(&pps, PTP_PPS_DEFAULTS);
>  		if (!ptp->pps_source) {
> +			err = -EINVAL;

Bonus points:  The function, pps_register_source(), keeps error codes
in a local variable, but it does not make use of the code.  There are
only five callers of that function, and so it would be nice to let
pps_register_source() return the error code.

For the present patch:

Acked-by: Richard Cochran <richardcochran@gmail.com>