From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] tcp: address problems caused by EDT misshaps
Date: Sat, 24 Nov 2018 17:42:20 -0800 (PST)
Message-ID: <20181124.174220.103125011987920229.davem@davemloft.net>
References: <20181124171224.28565-1-edumazet@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, ncardwell@google.com, ycheng@google.com,
        eric.dumazet@gmail.com
To: edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:59626 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726515AbeKYMcM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 25 Nov 2018 07:32:12 -0500
In-Reply-To: <20181124171224.28565-1-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <edumazet@google.com>
Date: Sat, 24 Nov 2018 09:12:24 -0800

> When a qdisc setup including pacing FQ is dismantled and recreated,
> some TCP packets are sent earlier than instructed by TCP stack.
> 
> TCP can be fooled when ACK comes back, because the following
> operation can return a negative value.
> 
>     tcp_time_stamp(tp) - tp->rx_opt.rcv_tsecr;
> 
> Some paths in TCP stack were not dealing properly with this,
> this patch addresses four of them.
> 
> Fixes: ab408b6dc744 ("tcp: switch tcp and sch_fq to new earliest departure time model")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.